Sockets - Shubha #28
Open
Sockets - Shubha #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses a different approach to get indexes for slicing
version includes optional enhancements
|
Grade the one that's named generator.rb please! :) I uploaded the other files just so I could have them in my repo. |
Portmanteau GeneratorWhat We're Looking For
|
dHelmgren
reviewed
Feb 18, 2019
| # test_consonant = "g" | ||
| # puts "Is #{test_consonant} a vowel?" | ||
| # puts is_vowel?(test_consonant) | ||
| # puts "in the run_generator method" |
There was a problem hiding this comment.
I would delete this dead code! It just muddies the waters when someone goes to look through it.
| # is_vowel checks to see if a specific character is a vowel | ||
| def is_vowel?(letter) | ||
| vowels = ["a", "e", "i", "o", "u"] | ||
| if vowels.include?(letter.downcase) |
| end | ||
|
|
||
| # is_vowel checks to see if a specific character is a vowel | ||
| def is_vowel?(letter) |
There was a problem hiding this comment.
So, personal style note, I'd move this function to the top of the code, because it gives context to what happens in your main program. Remember, your jobs are to 1) make it work good and 2) make it as easy to grok as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Portmanteau Generator
Congratulations! You're submitting your assignment.
Comprehension Questions
is_vowel?method affect your project?